Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic segmentation: model differs from paper #2

Closed
laurimi opened this issue May 29, 2018 · 2 comments
Closed

Semantic segmentation: model differs from paper #2

laurimi opened this issue May 29, 2018 · 2 comments

Comments

@laurimi
Copy link

laurimi commented May 29, 2018

Thanks for your code contribution! I read the paper, and noticed that the EdgeConv architecture (Figure 3) suggested for semantic segmentation is different from the one implemented in the code. In particular, the code uses two parallel pooling operations (max and mean instead of only max). Could you tell which one was used to obtain the results in the paper, and perhaps comment on reasons for the difference? Was using both max and mean aggregation better than only using either one alone?

@zeal-up
Copy link

zeal-up commented Nov 8, 2018

I have this issue too. And also, the segmentation model in your code is quite different from the paper. It seems that you only use edgeconv operation in the first mlp layer in each EdgeConv block for segmentation. While in the classification model, each mlp layer in EdgeConv block do the edgeconv operation.
And the concatenation operation is different from the paper.
@WangYueFt
Sorry to interrupt you, I just make sure that I did not understand it wrong.

@WangYueFt
Copy link
Owner

Hi,

Yes. The concatenation is different from what is in the paper. We will release the code exactly the same with the paper. Stay tuned!

Best,
Yue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants