Library development: error handling #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(also add a temporary new io_stopwatch to allow seedname to be deleted)
…r kpoint.dat read
Library development: error handling
jryates
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign of the handling of error conditions to ardently defer program exit to the calling program. Error conditions potentially generated in different parts of the code are caught after each subroutine call, returned up the call graph, and passed to the calling function as an error code together with informative message. This approach has been in part inspired by the work of Bálint Aradi on ErrorFx.
These changes represent "Stage 3" of the library developments described here: https://github.com/wannier-developers/wannier90/wiki/Code-restructure-(2021-2022)