Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace repo banner #39

Closed
warengonzaga opened this issue Oct 23, 2021 · 18 comments · Fixed by #44 or #49
Closed

replace repo banner #39

warengonzaga opened this issue Oct 23, 2021 · 18 comments · Fixed by #44 or #49
Assignees
Labels
hacktoberfest Hacktoberfest Related Pull Request or Issue. tweak Issue/Pull Request for Tweaks
Milestone

Comments

@warengonzaga
Copy link
Owner

since we have a new icon created by @thomasbnt, I'm thinking of updating the existing banner with the latest one.

@warengonzaga warengonzaga added tweak Issue/Pull Request for Tweaks hacktoberfest Hacktoberfest Related Pull Request or Issue. help wanted Issue Label for Asking Help good first issue Issue Label for Asking Help labels Oct 23, 2021
@thomasbnt
Copy link
Collaborator

Linked to this issue #37

@warengonzaga warengonzaga added this to the BuyMeaCoffeeJS v2 milestone Oct 23, 2021
@vivek32ta
Copy link
Contributor

Hi @thomasbnt I'd love to take this up. Thanks.

@thomasbnt
Copy link
Collaborator

I create the logo and I give you that.

@vivek32ta
Copy link
Contributor

And I have to make a banner and then put it in the readme? or do I just put the logo? I'm okay with both. :)

@warengonzaga
Copy link
Owner Author

And I have to make a banner and then put it in the readme? or do I just put the logo? I'm okay with both. :)

Just replace the repo banner in the README. I guess graphic design skills are needed. Create the same dimension I use for the banner for consistency, for the design just create your own make it simple as possible.

@vivek32ta
Copy link
Contributor

@warengonzaga I can do that, sure. Thanks.

@warengonzaga
Copy link
Owner Author

@warengonzaga I can do that, sure. Thanks.

Let's do it, just wait for @thomasbnt for the assets.

@vivek32ta
Copy link
Contributor

Yes yes definitely. @warengonzaga @thomasbnt

@vivek32ta
Copy link
Contributor

@warengonzaga @thomasbnt I made these two out of the assets that are already there. Did you guys like it? I can replace the logo once @thomasbnt sends the transparent one.

BuyMeACoffee JS Black Outline
BuyMeACoffee JS Yellow Outline

@warengonzaga
Copy link
Owner Author

@vivek32ta pay attention to BuyMeACoffee.JS it is supposed to be BuyMeaCoffee.JS
As per BMC officials, it is used as BuyMeaCoffeeJS.

@vivek32ta
Copy link
Contributor

vivek32ta commented Oct 23, 2021

Good catch. Will change that. How's the rest of it? And do you want the one with the black outline or the yellow outline

@warengonzaga
Copy link
Owner Author

Good catch. Will change that. How's the rest of it?

All good to me, @thomasbnt handle the final decision when it comes to branding.

@thomasbnt
Copy link
Collaborator

@warengonzaga @thomasbnt I made these two out of the assets that are already there. Did you guys like it? I can replace the logo once @thomasbnt sends the transparent one.

BuyMeACoffee JS Black Outline
BuyMeACoffee JS Yellow Outline

Maybe a yellow background ? I give you the logo in svg for better details this weekend or the week ahead

@vivek32ta
Copy link
Contributor

Maybe a yellow background? I give you the logo in svg for better details this weekend or the week ahead

I feel like the yellow background would meddle with the drink's color. That's why I went with white.

@warengonzaga
Copy link
Owner Author

any update on this? @thomasbnt it looks like @vivek32ta waiting for our response?

@warengonzaga warengonzaga added the waiting response Issue/Pull Request Label for Waiting Response label Oct 25, 2021
@thomasbnt
Copy link
Collaborator

any update on this? @thomasbnt it looks like @vivek32ta waiting for our response?

Yes, I was away this weekend. There is the package for square and rounded with shadow in 1000x1000 and 2000x2000 in SVG and PNG format.

https://drive.protonmail.com/urls/B42YYG7TDC#8BjKlPjK7m6F

@vivek32ta you can start the banner 💪🏼

@warengonzaga
Copy link
Owner Author

Awesome @thomasbnt!

@warengonzaga warengonzaga added in progress Issue/Pull Request Label for In Progress Status and removed waiting response Issue/Pull Request Label for Waiting Response labels Oct 26, 2021
@warengonzaga warengonzaga linked a pull request Oct 26, 2021 that will close this issue
@warengonzaga
Copy link
Owner Author

I'm happy to close this thanks for the great contribution @vivek32ta for the time and effort working on this. 👊😎

@warengonzaga warengonzaga removed in progress Issue/Pull Request Label for In Progress Status help wanted Issue Label for Asking Help good first issue Issue Label for Asking Help labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest Related Pull Request or Issue. tweak Issue/Pull Request for Tweaks
Projects
None yet
3 participants