Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement WordPress coding standards #7

Closed
ChristofLee opened this issue Oct 16, 2021 · 5 comments · Fixed by #16 or #17
Closed

implement WordPress coding standards #7

ChristofLee opened this issue Oct 16, 2021 · 5 comments · Fixed by #16 or #17
Labels
hacktoberfest Hacktoberfest Related Pull Request or Issue tweak Issue/Pull Request for Tweaks
Milestone
v1.1.0 📦

Comments

@ChristofLee
Copy link
Contributor

Things like:

  • Format of comments
  • PHP Doc blocks

I am happy to do this change, please let me know and update this issue with 'Hacktoberfest'.
@warengonzaga warengonzaga added the hacktoberfest Hacktoberfest Related Pull Request or Issue label Oct 16, 2021
@warengonzaga warengonzaga self-assigned this Oct 16, 2021
@warengonzaga warengonzaga added the tweak Issue/Pull Request for Tweaks label Oct 16, 2021
@warengonzaga warengonzaga added the in progress Issue/Pull Request Label for In Progress Status label Oct 16, 2021
@warengonzaga warengonzaga changed the title Implement WordPress coding standards implement WordPress coding standards Oct 16, 2021
@warengonzaga
Copy link
Owner

Hi, @ChristofLee agree, we can also use the OOP approach for this so we can maintain this project easily.

@ChristofLee
Copy link
Contributor Author

I agree.

How would you feel about using a boilerplate like "WordPress Plugin Boilerplate Generator | Ready to use WordPress Plugin Boilerplate" https://wppb.me then adding all our work so far to it.

However we decide, this would be a fairly big change. Perhaps we should have milestones, 1st to complete the in progress, 2nd look at this fairly big change.

@warengonzaga warengonzaga added in review Issue/Pull Request Label for In Review Status and removed in progress Issue/Pull Request Label for In Progress Status labels Oct 16, 2021
@warengonzaga
Copy link
Owner

I'll think a little about this. I'm following the same format here: https://www.youtube.com/playlist?list=PLriKzYyLb28kR_CPMz8uierDWC2y3znI2 his coding style is neat and clean.

@ChristofLee ChristofLee mentioned this issue Oct 18, 2021
Closed
@warengonzaga warengonzaga added in progress Issue/Pull Request Label for In Progress Status and removed in review Issue/Pull Request Label for In Review Status labels Oct 19, 2021
@warengonzaga warengonzaga linked a pull request Oct 23, 2021 that will close this issue
v1.1.0 update #16
Merged
@ChristofLee
Copy link
Contributor Author

Please see new PR for this issue #17 . Sorry the old PR was stale so needed to start a fresh branch.

I followed in regards to the format of comments. Everything else is now WP Standards.

@ChristofLee ChristofLee mentioned this issue Oct 24, 2021
Merged
@warengonzaga warengonzaga removed the in progress Issue/Pull Request Label for In Progress Status label Oct 25, 2021
@warengonzaga warengonzaga linked a pull request Oct 25, 2021 that will close this issue
Format file with PHPCBF #17
Merged
@warengonzaga warengonzaga added this to the Shortcodes WP v1.1.0 milestone Oct 25, 2021
@warengonzaga
Copy link
Owner

Closing this now since #17 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest Related Pull Request or Issue tweak Issue/Pull Request for Tweaks
Projects
None yet
Milestone
v1.1.0 📦
Development

Successfully merging a pull request may close this issue.

v1.1.0 update warengonzaga/shortcodes-wp
Format file with PHPCBF ChristofLee/shortcodes-wp
2 participants
@ChristofLee @warengonzaga