Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed NodeInfo #1020

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

removed NodeInfo #1020

wants to merge 17 commits into from

Commits on Sep 23, 2024

  1. Split overlays into discrete functionality and test 

    - Closes warewulf#987

To make the overlays testable in isolation, and after discussion with
the TSC, removed host/time/source from overlay files.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
    @anderbubble @mslacken
    anderbubble authored and mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    750eea9 View commit details
    Browse the repository at this point in the history

  2. Fix wwlog.Output format strings during overlay show 

    Signed-off-by: Jonathon Anderson <janderson@ciq.com>
    @anderbubble @mslacken
    anderbubble authored and mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0c70ddf View commit details
    Browse the repository at this point in the history

  3. Remove test/batch-test.go 

    Tests already exist for this at internal/pkg/batch/batch_test.go

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
    @anderbubble @mslacken
    anderbubble authored and mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5b8369f View commit details
    Browse the repository at this point in the history

  4. Omit internal tests from overlay installation 

    Signed-off-by: Jonathon Anderson <janderson@ciq.com>
    @anderbubble @mslacken
    anderbubble authored and mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4d834d5 View commit details
    Browse the repository at this point in the history

  5. removed NodeInfo and using NodeConf instead 

    This is a significant change in the undelying data model!

nodeDb, err := node.New()

will result in a structure which contains the on disk
values. Only

nodeDb.FindAllNodes() or nodeDb.GetNode(id) will give
the nodes with its merged in profiles.

Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    aa5b614 View commit details
    Browse the repository at this point in the history

  6. wwctl commands without NodeInfo 

    mostly remove Get and calls for the id

Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d6465fe View commit details
    Browse the repository at this point in the history

  7. api changes for use without NodeInfo 

    Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f274d01 View commit details
    Browse the repository at this point in the history

  8. fix test to run without NodeInfo 

    Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    36c6a7b View commit details
    Browse the repository at this point in the history

  9. use yaml/v3 and don't export Nodes 

    introduced wwbool and don't export
Nodes and NodeConfs. This requires new
explict Yaml (un)marshaling as the standard
marshaller won't touch these fields

Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    730321d View commit details
    Browse the repository at this point in the history

  10. added new types for primitves 

    this types like WWbool are needed so that they can
have their own command line parses which allows a UNDEF
for e.g. bool or ints.

Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    25b8ee6 View commit details
    Browse the repository at this point in the history

  11. update to yaml/v3 for project files 

    Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    617e9ce View commit details
    Browse the repository at this point in the history

  12. changes for yaml/v3 for wwctl commands 

    Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    be98ec6 View commit details
    Browse the repository at this point in the history

  13. api changes to modify unexported fields 

    changes can now not be done directly but must
go to SetNode or SetProfile. Although its also
now possible to access the field direclty with
GetNodePtr

Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9adf166 View commit details
    Browse the repository at this point in the history

  14. updated test for yaml/v3 

    Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ad1ec39 View commit details
    Browse the repository at this point in the history

  15. updated overlays 

    Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8d1a150 View commit details
    Browse the repository at this point in the history

  16. don't use net.IPMask 

    net.IPMask doesn't have any advantages, as it would
marshalled to
mask:
  - 1
  - 2
  - 3
  - 4

Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    083ccf4 View commit details
    Browse the repository at this point in the history

  17. updated testsafter test splitting 

    tests are updated as
* Get isn't possible any more
* defaults.conf isn't there any more
* bools are now not strings any more in yaml

Signed-off-by: Christian Goll <cgoll@suse.com>
    @mslacken
    mslacken committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c20cc72 View commit details
    Browse the repository at this point in the history