Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can use dye on signs #77

Closed
SeruhioX opened this issue May 15, 2020 · 2 comments
Closed

Users can use dye on signs #77

SeruhioX opened this issue May 15, 2020 · 2 comments

Comments

@SeruhioX
Copy link

I leave the issue here so you watch it when you can.

If I make a "[buy]" sign in which the item inside the chest is a dye, users can use this object to change the color of the letters of the sign and disable it.
Bypassing the WorldGuard restrictions, this doesn't happen if the item to buy is not a dye.

Signshop 3.4.4
PaperSpigot 1.15.2

error: https://gyazo.com/89b2a585d9fbe5ebb0f868ab0a174ff4
ITEM: https://i.gyazo.com/ae25ad0d3a4858769e84f206412e709d.png
plugins: https://i.gyazo.com/4341808271111efdb6ecb04d0d35b6b7.png

@weaves7 weaves7 added the Bug label Aug 10, 2020
@weaves7
Copy link
Collaborator

weaves7 commented Nov 25, 2020

Do you still have this problem with the latest version? I have not been able to reproduce the issue.

@weaves7 weaves7 closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2022
@weaves7 weaves7 reopened this Aug 20, 2022
@weaves7
Copy link
Collaborator

weaves7 commented Aug 20, 2022

unknown

Thangss — Today at 2:13 PM
oh

Eman — Today at 2:13 PM
Checked the trustlist in that place, she doesn't have any trust
[2:13 PM]

Thangss — Today at 2:14 PM
So she bought the glow ink, and it used one on the sign, interesting. I tried with reg dye at Ikea and that didnt hppen. Might just be glow ink

Eman — Today at 2:14 PM
Yeah could be

Weaves — Today at 2:16 PM
Sounds similar to this issue that was reported but I could never duplicate it and the reporter disappeared. #77
[2:17 PM]
Could you provide as much information about that issue as you can?

Thangss — Today at 2:17 PM
I dont think it's being disabled tho.

Weaves — Today at 2:17 PM
Still probably shouldn't be able to dye someone elses shop

Thangss — Today at 2:19 PM
2022-08-20_15 18 57

[2:19 PM]
pretty much sums it up. It dyed the sign, charged me for it, and I didnt get the glow ink sac
[2:20 PM]
I was able to buy a second one no problem

Eman — Today at 2:20 PM
Yeah seems like if u buy it it uses it at the same time, and doesn't care about the claim when u do both at the same time

Thangss — Today at 2:20 PM
Yeah I have trust in that claim

Eman — Today at 2:22 PM
Welp, I just tried it without trust and it still did it

Weaves — Today at 2:26 PM
well now that I know how to reproduce the issue i may be able to fix it. And it would be a good time to add the dye on purpose feature

Message #support

@weaves7 weaves7 removed the Stale label Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants