Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update workflows to accommodate repository name and default branch changes #126

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

mbtamuli
Copy link
Contributor

@mbtamuli mbtamuli commented Jan 22, 2024

Closes #125

Although the PR was raised to help out in making changes related to #105, this PR should also fix #125. Not linking this PR to close #105 as there'll be other PRs for fully closing that issue.

Signed-off-by: Mriyam Tamuli <mbtamuli@gmail.com>
@mbtamuli mbtamuli requested a review from a team as a code owner January 22, 2024 07:49
Signed-off-by: Mriyam Tamuli <mbtamuli@gmail.com>
@mugdha-adhav
Copy link
Collaborator

Approved the PR.

On a related note, I wonder if our CI is currently failing since the repository name change. Have you seen any failures yet @mbtamuli?

@mbtamuli
Copy link
Contributor Author

On a related note, I wonder if our CI is currently failing since the repository name change. Have you seen any failures yet @mbtamuli?

Nope, I haven't seen any failures.

@mbtamuli
Copy link
Contributor Author

Please hold before merging this PR. @mugdha-adhav

@mbtamuli mbtamuli marked this pull request as draft January 22, 2024 08:04
@mugdha-adhav
Copy link
Collaborator

I wonder if our CI is currently failing since the repository name change.

I see that the CI builds are not getting triggered for #127.

@mbtamuli
Copy link
Contributor Author

@mugdha-adhav This is ready to merge. I was trying to add some stuff regarding dev container, will create a separate issue and/or PR for it.

@mugdha-adhav mugdha-adhav merged commit 03636ae into warm-metal:main Jan 22, 2024
12 checks passed
@mbtamuli mbtamuli deleted the build/update-workflows branch January 22, 2024 09:30
@mbtamuli
Copy link
Contributor Author

Not linking this PR to close #105 as there'll be other PRs for fully closing that issue.

My attempt at not linking this PR to close the issue #105 failed 😅 . Hadn't realised GitHub checks the whole description. Will be careful next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants