Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE 💡] Enhancements for Light mode #107

Closed
4 tasks done
warmachine028 opened this issue Oct 5, 2023 · 7 comments · Fixed by #108
Closed
4 tasks done

[FEATURE 💡] Enhancements for Light mode #107

warmachine028 opened this issue Oct 5, 2023 · 7 comments · Fixed by #108
Assignees
Labels
enhancement Improvement to a feature ⭐ goal: addition good first issue The issue is to encourage first time contributors hacktoberfest This issue/pull request is specially marked for hacktoberfest help wanted 🤩 Up for the grab The issue is ready to be assigned to a contributor

Comments

@warmachine028
Copy link
Owner

warmachine028 commented Oct 5, 2023

Description

  • During development of the Dark mode, various texts were converted to white color for visibility in both modes properly.
  • But some colors fit only the Light mode perfectly. Hence some changes are to be brought back.
  • All of these changes are to be made for Light theme without hampering the existing colors or UI of the Dark theme
  • Your changes should be compatible with all devices, check responsive properly especially for mobile devices.
  • Change the Post Upload Form Title color to Black.
  • The post title font should be a bit increased.
  • The Comment Text area has a white background, this must be removed.
  • Bring back the changes in Light theme which existed in previous Deployment without hampering the dark mode UI.
  • Take reference from the old deployment to apply these changes.

Screenshots

Previous Deployment for Light mode

  • Screenshot_2023-10-06-00-25-38-236_com android chrome

Current Deployment for Light mode

  • Screenshot_2023-10-06-00-28-04-523_com android chrome

Additional information

  • Always use styled components instead of plain CSS and MUI components.

Make sure to read the CONTRIBUTING and SETUP docs before proceeding

Happy contributing. 💐

Star my other Repositories here

@warmachine028 warmachine028 added enhancement Improvement to a feature help wanted good first issue The issue is to encourage first time contributors hacktoberfest This issue/pull request is specially marked for hacktoberfest 🤩 Up for the grab The issue is ready to be assigned to a contributor ⭐ goal: addition labels Oct 5, 2023
@warmachine028 warmachine028 pinned this issue Oct 6, 2023
@Tholkappiar

This comment was marked as abuse.

@warmachine028

This comment was marked as outdated.

@Tholkappiar

This comment was marked as spam.

@warmachine028

This comment was marked as outdated.

@Faisalhs51
Copy link
Contributor

Basically you want text colors from previous deployment back in the light mode.
Assign this to me.

@warmachine028
Copy link
Owner Author

Basically you want text colors from previous deployment back in the light mode. Assign this to me.

Assigned let me know if any query arises, I'll assist you

@Tholkappiar

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to a feature ⭐ goal: addition good first issue The issue is to encourage first time contributors hacktoberfest This issue/pull request is specially marked for hacktoberfest help wanted 🤩 Up for the grab The issue is ready to be assigned to a contributor
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants