Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove messages-filled mask remains and other masks #66

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

BalbinaK
Copy link
Contributor

@BalbinaK BalbinaK commented Dec 5, 2023

This PR removes a remaining masked path from message-filled icon.

Before:
Message-filled with white background in a pink container

After:
Message-filled with transparent background in a pink container

In addition this PR removes masks used in shoes, vacuum and car-part icons as they were redundant and could cause problems when their IDs were not unique across a document. That could lead to situations like this:
Screenshot of car-part-32 icon being clipped at 16x16

@BalbinaK BalbinaK requested a review from a team December 5, 2023 15:50
@BalbinaK BalbinaK merged commit e4d9112 into next Dec 11, 2023
1 check passed
@BalbinaK BalbinaK deleted the chore/remove-redundant-masks-from-svgs branch December 11, 2023 06:18
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
# [1.4.0-next.4](v1.4.0-next.3...v1.4.0-next.4) (2023-12-11)

### Bug Fixes

* remove messages-filled mask remains and other masks ([#66](#66)) ([e4d9112](e4d9112))
github-actions bot pushed a commit that referenced this pull request Dec 12, 2023
# [1.4.0](v1.3.0...v1.4.0) (2023-12-12)

### Bug Fixes

* remove messages-filled mask remains and other masks ([#66](#66)) ([e4d9112](e4d9112))
* update market and twitter icons ([#65](#65)) ([b9360bb](b9360bb))

### Features

* add new icons ([#63](#63)) ([55fd810](55fd810))
* add sweater and baby-onesie icons ([#68](#68)) ([c3d10b5](c3d10b5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants