Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor performance on large files #8

Closed
ershovdz opened this issue Mar 24, 2023 · 6 comments
Closed

Poor performance on large files #8

ershovdz opened this issue Mar 24, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ershovdz
Copy link

Poor performance when open the attached obj file.
Opening file takes too much time and memory. But if I open the same file in https://3dviewer.net/# it opens very fast.
Penthouse.zip

@ershovdz ershovdz added the bug Something isn't working label Mar 24, 2023
@kroko
Copy link
Member

kroko commented Mar 24, 2023

Confirmed

After second check it seems that https://3dviewer.net/ behaves slow for this model too, both by uploading Penthouse-org.obj as well as passing it as URL, thus your premise IMHO actually does not stand. I used browser in no cache mode to validate (but did not quantise my observation, just subjective feel for timing and behaviour).

Here are CORS'ed versions that can be loaded in 3dviewer.net via Open from URL promt

Other 3D viewers choke on your file too.

OBJ weighting 54MB means huge tree. Autodesk case hints though that there might be some internal representation tricks.

Needs more investigation, but maybe this case just represents limits on what JS / WebGL 2 (no WebGPU at this point) on top on Three.js can do.

@kroko kroko self-assigned this Mar 24, 2023
@kroko kroko added enhancement New feature or request and removed bug Something isn't working labels Mar 24, 2023
@kroko kroko changed the title Poor performance Poor performance on large files Mar 24, 2023
@ershovdz
Copy link
Author

ershovdz commented Mar 24, 2023

Just to make it clear.
My configuration: Windows 11 22H2, Nvidia 3060, 32 Gb Ram, CPU Amd Ryzen 5800H.
I use this url to open in browsers for 3dviewer:
https://3dviewer.net/#model=https://bucket.cdn-d01.warp.lv/user-ershovdz/Penthouse-org.obj
Clear cache in browsers. Open url.
Chrome (latest version): 10 seconds and 900 Mb ram
Firefox (latest version): 15 seconds and 800 Mb ram

I use this url for nextcloud app files3dmodel viewer for the same file:
http://localhost:8080/apps/files/?dir=/&openfile=4893
Clear cache in browsers. Open url.
Chrome (latest version): 19 seconds and 3000 Mb ram
Firefox (latest version): didn't wait for opening (more 90 seconds) and it took 5000 Mb of ram
firefox

https://fetchcfd.com/3d-viewer opens this file for only 4 seconds and use only 900 Mb in Chrome !

@ershovdz
Copy link
Author

Looks like I've found the root cause. Just remove this line:

viewerObj: null,

It's disable vue reactivity for viewer.

@kroko
Copy link
Member

kroko commented May 3, 2023

note to myself: @AbsolutePhoenix in #12 has found that it happens above 16MB mark for STL files.

@kroko kroko added bug Something isn't working and removed enhancement New feature or request labels May 3, 2023
@kroko
Copy link
Member

kroko commented Jun 25, 2023

@ershovdz please try 0.0.11 with your Penthouse.zip

@kroko
Copy link
Member

kroko commented Jun 26, 2023

if the issue persists, please report and i will reopen this ticket.

@kroko kroko closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants