Trait method to add conditions for SSH agent server when accepting requests for operations #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Could you please check the |
|
Perfect! @all-contributors please add @gotlougit for code |
|
I've put up a pull request to add @gotlougit! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #165
The
russh_keys::agent::server::Agenttrait now has another async trait we can define if necessary which will check if we should be able to perform a given operation or not. External developers can implement this trait method with their own code, allowing the request to fail if necessary.The operation types are represented in a newly created
MessageTypeenum and passed into this new method. By default, the method returns true, so old code shouldn't be affected by this change.