Selection: fixed selection on Linux with virtual folders like /dev #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly using {ino,dev} as file ID but on Linux
there may be virtual folders that have no unique ino like /proc, /dev.
This broke selection/navigation on `/` on Linux / WSL since several
folders could end up having the same ID.
This PRs still uses ino + dev when possible and falls back
to the string `${ino}-${dev}-${path}` for virtual folders.
This fixes the navigation on `/` on *nix while still keeping
nice features, like renaming a selected file will still reselect
the correct file when the folder is refreshed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly using
{ino,dev}as file ID but on Linux there may be virtual folders that haveno unique ino like /proc, /dev.
This broke selection/navigation on
/on Linux / WSL since several folders could end up having the same ID.This PRs still uses ino + dev when possible and falls back to the string
${ino}-${dev}-${path}for virtual folders.This fixes the navigation on
/on *nix while still keeping nice features, like renaming a selected file will still reselect the correct file when the folder is refreshed.