Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mode 2027/grapheme cluster handling #4190

Open
paperdave opened this issue Feb 18, 2024 · 2 comments
Open

Support mode 2027/grapheme cluster handling #4190

paperdave opened this issue Feb 18, 2024 · 2 comments
Labels
Feature requests Feature Requests

Comments

@paperdave
Copy link

Discord username (optional)

paperdave.net

Describe the solution you'd like?

Certain graphemes such as क्षि, 👩‍🌾, 🏳️‍⚧️, 각, and many more are made up of multiple unicode code points. These currently render as individual code points.

image

A good read on what is going on here is a blog post by Mitchell Hashimoto: Grapheme Clusters and Terminal Emulators. He's done alot of work to make this fast and reliable in Ghostty.

I am specifically requesting Warp to implement Mode 2027, a proposal for proper grapheme cluster support.

The specification for grapheme clustering describes exactly where graphemes break. Likely should find a library in the programming language Warp is built in, as the rules are very complicated and easy to get wrong.

Is your feature request related to a problem? Please describe.

No response

Additional context

I'm writing a terminal text input library and it would be great if Warp supported this, though I think for warp specifically I'm going to see if I

How important is this feature to you?

1 (Not too important)

Warp Internal (ignore) - linear-label:39cc6478-1249-4ee7-950b-c428edfeecd1

None

@dannyneira
Copy link
Member

Thanks for this feature request @paperdave

To anyone else interested in this feature, please add a 👍 to the original post at the top to signal that you want this feature, and subscribe if you'd like to be notified.

@christianparpart
Copy link

@dannyneira not sure "Thumps up" is the correct metric here. Users will only start to notice and complain when there's something broken-looking, and not request it to look good without having noticed the difference. DEC mode 2027 is something purely technical that is hard to evaluate from a pure user's point of view. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature requests Feature Requests
Projects
None yet
Development

No branches or pull requests

4 participants