Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: smartLink.html should normalize path before comparing #55

Open
warriordog opened this issue Oct 4, 2020 · 0 comments
Open

Docs: smartLink.html should normalize path before comparing #55

warriordog opened this issue Oct 4, 2020 · 0 comments
Labels
tech debt Technical / code quality improvements

Comments

@warriordog
Copy link
Owner

The smartLink component currently does a basic string replace to normalize the URLs that it compares, but this in insufficient. A better implementation should use or reproduce the same logic that is used in the pipeline for resolving anchor tags.

This will be easier to do after / during #28.

@warriordog warriordog added the tech debt Technical / code quality improvements label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical / code quality improvements
Projects
None yet
Development

No branches or pull requests

1 participant