Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Refactor how glue positioning is handled on scroll #342

Merged
merged 1 commit into from
Mar 17, 2016

Commits on Mar 17, 2016

  1. Refactor how glue positioning is handled on scroll

    Previously, there were a couple hot spots that would cause glue to
    jump prematurely to the top or bottom on scroll when unexpected.
    
    This commit simplifies and reworks the logic a bit to better maintain
    the state of `#glue` when the content is larger than the navigation.
    
    * Set an upper bound for the `top` style attribute on `#spine`
    * Watch for any positioning above 0 and reset to 0.
    * Watch for any positioning outside the upper bound and reset to
      the upper bound.
    
    Fixes #266.
    jeremyfelt committed Mar 17, 2016
    Configuration menu
    Copy the full SHA
    2dd0fcd View commit details
    Browse the repository at this point in the history