Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaN Canonicalization #1269

Closed
syrusakbary opened this issue Mar 5, 2020 · 2 comments
Closed

NaN Canonicalization #1269

syrusakbary opened this issue Mar 5, 2020 · 2 comments
Labels
🎉 enhancement New feature! 📦 lib-compiler-singlepass About wasmer-compiler-singlepass 📦 lib-deprecated About the deprecated crates

Comments

@syrusakbary
Copy link
Member

syrusakbary commented Mar 5, 2020 •
edited by MarkMcCaskey
Loading

Wasmer should provide a way to standardize NaNs in our Singlepass backend so all the float (NaN) operations are deterministic regardless of the backend
@syrusakbary syrusakbary added 🎉 enhancement New feature! 📦 lib-deprecated About the deprecated crates 📦 lib-compiler-singlepass About wasmer-compiler-singlepass labels Mar 5, 2020
@syrusakbary
Copy link
Member Author

Once this is merged:
#1303

We should be ready to close the PR.

Note: the implementation only covers X86 chipset instructions. We don't yet support full canonicalization in ARM chipsets (Aarch64)

@syrusakbary
Copy link
Member Author

Closing as we now support NaN canonicalization across all compilers

@ailisp ailisp mentioned this issue Jan 14, 2021
Closed
@webmaster128 webmaster128 mentioned this issue Jul 15, 2021
Closed
@oberstet oberstet mentioned this issue Mar 20, 2023
Closed
@RogerKSI RogerKSI mentioned this issue Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-compiler-singlepass About wasmer-compiler-singlepass 📦 lib-deprecated About the deprecated crates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@syrusakbary