-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add Wasm based benchmarking #443
Comments
Today I experimented with running For this I followed the user guide linked above: User Guide
criterion = { version = "0.4.0", default-features = false }
Note: This will already run
|
This has been implemented in #483. Closed. |
Since the PR for #322 was merged recently we now have a benchmarking CI.
However, the current benchmark CI only checks native performance while
wasmi
is mainly used as a WebAssembly binary executed via the Wasmtime engine.Therefore having additional Wasm based testruns is really important information for us, too.
The current table that the CI outputs is as follows:
compile_and_validate
instantiate
execute_foo
etc.
With additional Wasm based tests we need more columns:
compile_and_validate
instantiate
execute_foo
Criterion has a whole section as to how to benchmark Criterion benchmarks as Wasm:
https://github.com/bheisler/criterion.rs/blob/5e27b692a43a05736d073fd449e16dcf1c24628c/book/src/user_guide/wasi.md
The text was updated successfully, but these errors were encountered: