Skip to content

Commit

Permalink
Updates CRA from v4 to v5 (#771)
Browse files Browse the repository at this point in the history
  • Loading branch information
shayneczyzewski committed Oct 19, 2022
1 parent e3ce6d6 commit dc036f5
Show file tree
Hide file tree
Showing 15 changed files with 17 additions and 21 deletions.
3 changes: 3 additions & 0 deletions waspc/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## v0.x.x.x (TBD)

### BREAKING CHANGES
- Updates Create React App from version 4.0.3 to 5.0.1. This brings many improvements as well as downstream library updates. It also has a list of possible breaking changes: https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md

### [NEW FEATURE] Dockerfile customization

You can now customize the default Wasp Dockerfile by either extending/replacing our build stages or using your own custom logic. To make use of this feature, simply add a Dockerfile to the root of your project and it will be appended to the bottom of the existing Wasp Dockerfile.
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion waspc/examples/todoApp/ext/Todo.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const Task = (props) => {
// cache is empty
return [updatedTask];
} else {
return oldTasks.map(task => task.id == updatedTask.id ? { ...task, ...updatedTask } : task)
return oldTasks.map(task => task.id === updatedTask.id ? { ...task, ...updatedTask } : task)
}
}
}]
Expand Down
5 changes: 1 addition & 4 deletions waspc/src/Wasp/Generator/WebAppGenerator.hs
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,7 @@ npmDepsForWasp _spec =
("react-dom", "^17.0.2"),
("react-query", "^3.39.2"),
("react-router-dom", "^5.3.3"),
("react-scripts", "4.0.3"),
-- NOTE: We need to specify this exact version of `react-error-overlay` for use with
-- `react-scripts` v4 due to this issue: https://github.com/facebook/create-react-app/issues/11773
("react-error-overlay", "6.0.9")
("react-scripts", "5.0.1")
],
-- NOTE: In order to follow Create React App conventions, do not place any dependencies under devDependencies.
-- See discussion here for more: https://github.com/wasp-lang/wasp/pull/621
Expand Down

0 comments on commit dc036f5

Please sign in to comment.