Updates CRA from v4 to v5

[shayneczyzewski]

Description

Updates Create React App from v4 to v5. It is pretty straightforward:

• https://create-react-app.dev/docs/updating-to-new-releases/
• https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md#migrating-from-40x-to-500

The only drag is we do have a couple of deprecation warnings (however, this is a known CRA5 issue that will hopefully be fixed soon: facebook/create-react-app#11860):

Web app (stderr): (node:10363) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Web app (stderr): (Use `node --trace-deprecation ...` to show where the warning was created)
Web app (stderr): (node:10363) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
Web app (stderr): Starting the development server...

If we really wanted to hide it, we could filter the web app output.

Fixes most deprecation warnings from: #181 (The only ones left are stable, w3c-hr-time, and svgo. But down from 21 before upgrade. And far fewer npm audit errors.)

The goal for this is to make it easier to add Tailwind support as a next step (https://tailwindcss.com/docs/guides/create-react-app).

Type of change

Please select the option(s) that is more relevant.

• Code cleanup
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

⚠️Help Wanted⚠️

How should I be thinking about testing this? I ran the existing apps and they seem ok. Since CRA helps with frontend in dev mode, deployment should not be a concern, right? Anything else to consider/test/validate?

[shayneczyzewski]

This was a CRA4-only bug.

[sodic]

LGTM!

[sodic]

How should I be thinking about testing this? I ran the existing apps and they seem ok. Since CRA helps with frontend in dev mode, deployment should not be a concern, right? Anything else to consider/test/validate?

If the apps work (with both compile and start), I think we're good.

[Martinsos]

Awesome that we will now have less of those deprecation warnings!

[Martinsos]

How should I be thinking about testing this? I ran the existing apps and they seem ok. Since CRA helps with frontend in dev mode, deployment should not be a concern, right? Anything else to consider/test/validate?

If the apps work (with both compile and start), I think we're good.

Ah sorry forgot to comment on this: yup I agree with @sodic , that should be enough of testing for now!

[shayneczyzewski]

Thanks for the review here @sodic and @Martinsos. I forgot to add the Changelog update for the possible breaking change (I will link to the CRA4 to 5 transition doc). After that, I will merge! 🚀