-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs updates for OAuth overhaul #1890
Conversation
infomiho
commented
Mar 14, 2024
•
edited
Loading
edited
- Migration docs from 0.12 to 0.13
- Updates to Google docs
- Updates to Github docs
53f42c7
to
feaf1b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I didn't run or check the code (I'm guessing you already covered that :).
My comments include suggestions you can implement or ignore. Merge when ready.
web/docs/auth/social-auth/google.md
Outdated
] | ||
``` | ||
|
||
The fields you receive will depend on the scopes you requested. The default scope is set to `profile` only. If you want to get the user's email, you need to specify the `email` scope in the `configFn` function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fields you receive will depend on the scopes you requested. The default scope is set to `profile` only. If you want to get the user's email, you need to specify the `email` scope in the `configFn` function. | |
The fields you will receive depend on the scopes you requested. The default scope is set to `profile` only. If you want to get the user's email, you need to specify the `email` scope in the `configFn` function. |
Maybe even without will
, applies to other places too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A common theme for the suggestions (I might have missed some along the same lines).
I suggest you use:
- "We" when you talk about the team (e.g., "we made some breaking changes...")
- "Wasp" when you talk about the framework (e.g., "Wasp gives you access to this field").
The redirect URL for the OAuth providers has changed. You will need to update the redirect URL for the OAuth providers in the provider's dashboard. | ||
|
||
<Tabs> | ||
<TabItem value="before" label="Before"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the before and after stuff, but it seems we lost the javascript/typescript split and this guide therefore only supports typescript?
No big deal, but just FYI to consider whether it makes sense in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was deciding between having the complete matrix [ts, js] x [before, after] or not. It seemed cleaner to include only one of those: most people use Typescript and those using Javascript will get the idea of what needs to change.
I'll merge this after we merge Github and Google changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, merge when ready!
5813990
to
13b0c5c
Compare
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
5f2814c
to
f00729a
Compare