Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manually.md (railway) #2108

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Update manually.md (railway) #2108

merged 2 commits into from
Jun 20, 2024

Conversation

jolle11
Copy link
Contributor

@jolle11 jolle11 commented Jun 20, 2024

Add caution alert to the railway setup.

Description

Describe your PR! If it fixes specific issue, mention it with "Fixes # (issue)".

Select what type of change this PR introduces:

  1. Just code/docs improvement (no functional change).
  2. Bug fix (non-breaking change which fixes an issue).
  3. New feature (non-breaking change which adds functionality).
  4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. I updated ChangeLog.md with description of the change this PR introduces.
  2. I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Update example apps if needed

If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:

  1. I updated waspc/examples/todoApp as needed (updated modified feature or added new feature) and manually checked it works correctly.
  2. I updated waspc/headless-test/examples/todoApp and its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).

jolle11 and others added 2 commits June 20, 2024 16:59
Add caution alert to the railway setup.
@Martinsos
Copy link
Member

Thanks @jolle11 !

I added a commit on top, which did the following:

  1. I moved the change from 0.13 docs version to "next" version -> meaning it will be released with the next wasp release and not immediately, but at least we don't need to add to two places.
  2. I removed it form the caution box and put it direclty next to the link examples -> I htink it will be more obvious that way!

@Martinsos Martinsos merged commit 8d90a3a into wasp-lang:release Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants