Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates CRA from v4 to v5 #771

Merged
merged 7 commits into from
Oct 19, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion waspc/examples/todoApp/ext/Todo.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const Task = (props) => {
// cache is empty
return [updatedTask];
} else {
return oldTasks.map(task => task.id == updatedTask.id ? { ...task, ...updatedTask } : task)
return oldTasks.map(task => task.id === updatedTask.id ? { ...task, ...updatedTask } : task)
}
}
}]
Expand Down
5 changes: 1 addition & 4 deletions waspc/src/Wasp/Generator/WebAppGenerator.hs
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,7 @@ npmDepsForWasp _spec =
("react-dom", "^17.0.2"),
("react-query", "^3.39.2"),
("react-router-dom", "^5.3.3"),
("react-scripts", "4.0.3"),
-- NOTE: We need to specify this exact version of `react-error-overlay` for use with
-- `react-scripts` v4 due to this issue: https://github.com/facebook/create-react-app/issues/11773
("react-error-overlay", "6.0.9")
Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a CRA4-only bug.

("react-scripts", "5.0.1")
shayneczyzewski marked this conversation as resolved.
Show resolved Hide resolved
],
-- NOTE: In order to follow Create React App conventions, do not place any dependencies under devDependencies.
-- See discussion here for more: https://github.com/wasp-lang/wasp/pull/621
Expand Down