Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Fly.io to deployment guide #803

Merged
merged 10 commits into from
Nov 10, 2022
Merged

Adds Fly.io to deployment guide #803

merged 10 commits into from
Nov 10, 2022

Conversation

shayneczyzewski
Copy link
Sponsor Contributor

@shayneczyzewski shayneczyzewski commented Nov 7, 2022 •
edited
Loading

Description

Adds a section on deploying to Fly.io due to Heroku removing their free hosting option later this month.

The reason I chose Fly.io is they have great Dockerfile support: https://fly.io/docs/languages-and-frameworks/dockerfile/

The Dockerfile support on Render seems to assume it will be in your GitHub repo, which is hard for us to support with our .wasp/build structure: https://render.com/docs/docker#getting-started-with-docker

TODO:

  • Rebase from main to release
  • Change Heroku from "deprecated" to "paid"
  • Go through docs/bog and remove Heroku references (or disclaimers)

Fixes #767

Type of change

Please select the option(s) that is more relevant.

  • Code cleanup
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@shayneczyzewski shayneczyzewski changed the base branch from release to main November 7, 2022 13:58
@shayneczyzewski shayneczyzewski changed the title Adds Fly.io to deployment guide WIP: Adds Fly.io to deployment guide Nov 7, 2022
Martinsos
Martinsos approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work @shayneczyzewski !
The only thing that comes to mind is not marking Heroku as deprecated, but as "not-free" or "paid" or smth like that -> since you could still deploy there if you wish, and some people might, and our instruction are still correct.

@shayneczyzewski
Copy link
Sponsor Contributor Author

Looks good, nice work @shayneczyzewski ! The only thing that comes to mind is not marking Heroku as deprecated, but as "not-free" or "paid" or smth like that -> since you could still deploy there if you wish, and some people might, and our instruction are still correct.

Ah yes, good point. I will make that change. Thanks for the review! 🙌🏻

@shayneczyzewski shayneczyzewski changed the base branch from main to release November 7, 2022 15:34
@shayneczyzewski shayneczyzewski changed the title WIP: Adds Fly.io to deployment guide Adds Fly.io to deployment guide Nov 7, 2022
@shayneczyzewski shayneczyzewski marked this pull request as ready for review November 7, 2022 15:52
@shayneczyzewski @matijaSos
Update web/blog/2022-10-28-farnance-hackathon-winner.md
d009782 
Co-authored-by: Matija Sosic <matija.sosic@gmail.com>
vincanger
vincanger reviewed Nov 10, 2022
View reviewed changes
web/docs/deploying.md Outdated Show resolved Hide resolved
vincanger
vincanger reviewed Nov 10, 2022
View reviewed changes
web/docs/deploying.md Show resolved Hide resolved
web/docs/deploying.md Show resolved Hide resolved
@shayneczyzewski shayneczyzewski merged commit 5f48dd0 into release Nov 10, 2022
@shayneczyzewski shayneczyzewski deleted the shayne-fly-deployment-guide branch November 10, 2022 15:53
sodic added a commit that referenced this pull request Nov 26, 2022
@sodic @matijaSos
@maksim36ua @Martinsos @shayneczyzewski @vincanger
Merge release to main (#844)
7c7e6b7 
* Added 'How Wasp got to 1k stars on gh' blog post.

* Docs update for Hacktoberfest (#731)

* Initial docs update for Hacktoberfest

* Contributing.md update

* Update "Before you begin" section

* Update web/docs/tutorials/dev-excuses-app/creating-the-project.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update the section names

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/contributing.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/contributing.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/contributing.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Add Discord component and some minor fixes

* Add unclear notice

* Update web/docs/pick-a-tutorial.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/getting-started.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Review updates

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update suggestion

* Update web/docs/tutorials/dev-excuses-app/perform-migration-and-run.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/perform-migration-and-run.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update

* Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Remove lines

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update getExcuse function

* Update page naming convention

* Remove Main.css

* Update migration text

* Update image

* Update "Wasp's compiler is built with Haskell"

* Add tutorials description

* Update web/docs/pick-a-tutorial.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update Discord link and tutorial ending

* Update links

Co-authored-by: mkhamrov <mkhamrov@redhat.com>
Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>
Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update to-do app tutorial links

* Fixed a bit 'how to get started with haskell in 2022' blog post.

* Small fix of 'Pick a Tutorial' doc page. (#737)

* Linked Copilot post to its HN discussion.

* Added Farnance showcase blog post.

* Improved messaging about node version in getting started page in docs.

* Added Beta announcement bar to the landing page and docs.

* Update Docusaurus (#797)

* Adds Fly.io to deployment guide (#803)

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>
Co-authored-by: vincanger <70215737+vincanger@users.noreply.github.com>

* Added Alpha Testing Program: post-mortem blog post.

* Update features.md newUser snippets

more explicit examples

* add railway deployment (#818)

* Added Hacktoberfest 2022 reflections blog post.

* update Railway client deployment

* add railway proxy warning

* Update image thumbnail (#832)

Co-authored-by: mkhamrov <mkhamrov@redhat.com>

* Added Beta Launch Week announcement post.

* small blog fix, updated thumbnail img.

* Added Michael Curry (cursorial) use case blog post.

* Added Erlis Kllogjri's Amicus use case blog post.

* Fixed some grammar errors in use case posts.

* first pass at both beta launch blog posts

* minor edits

* clean up Features, GoogleAuth, & Deploy docs (#820)

* add railway deployment

* clean up Features and GoogleAuth docs

* Update web/docs/language/features.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>
Co-authored-by: Martin Sosic <sosic.martin@gmail.com>

* Created new landing page for Beta.

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>
Co-authored-by: Max Khamrovskyi <maksim36ua@gmail.com>
Co-authored-by: mkhamrov <mkhamrov@redhat.com>
Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>
Co-authored-by: Martin Sosic <sosic.martin@gmail.com>
Co-authored-by: Shayne Czyzewski <523636+shayneczyzewski@users.noreply.github.com>
Co-authored-by: vincanger <70215737+vincanger@users.noreply.github.com>
Co-authored-by: shayneczyzewski <shayne.czyzewski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matijaSos matijaSos matijaSos left review comments

@vincanger vincanger vincanger left review comments

@Martinsos Martinsos Martinsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instead of Heroku being default deployment method, find smth else (Render?)
4 participants
@shayneczyzewski @Martinsos @matijaSos @vincanger