Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up Features, GoogleAuth, & Deploy docs #820

Merged
merged 5 commits into from
Nov 26, 2022
Merged

clean up Features, GoogleAuth, & Deploy docs #820

merged 5 commits into from
Nov 26, 2022

Conversation

vincanger
Copy link
Contributor

added some extra cleanliness and spiciness to Features and Deploy

@Martinsos
Copy link
Member

@vincanger something is wrong with this PR right? It seems to have too many commits/changes in it. I am guessing it is due to git stuff -> you will probably need to do some rebasing and figuring out what are you merging into what. Maybe your branch was created from release branch and now you are merging it into main? Let me know if you need some help.

@vincanger vincanger changed the base branch from main to release November 24, 2022 12:32
@vincanger
Copy link
Contributor Author

vincanger commented Nov 24, 2022 •
edited
Loading

whoops, yep @Martinsos . It was merging into main instead of release. I'll keep a closer eye on this next time

shayneczyzewski
shayneczyzewski reviewed Nov 26, 2022
View reviewed changes
web/docs/language/features.md
@@ -7,7 +7,7 @@ title: Features
There can be only one declaration of `app` type per Wasp project.
It serves as a starting point and defines global properties of your app.

```css
```c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to swap from css to c syntax here @vincanger? I think historically we used css for wasp syntax as it was closest to that. I would check with @Martinsos or @matijaSos for more on that. 👍🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @shayneczyzewski said -> but gave it a quick spin and I see that in this case c actually gives better result! It often depends on the specific code example. I am guessing Vince found all these examples to work better with c, so let's do it!

Martinsos
Martinsos approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

web/docs/language/features.md
@@ -7,7 +7,7 @@ title: Features
There can be only one declaration of `app` type per Wasp project.
It serves as a starting point and defines global properties of your app.

```css
```c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @shayneczyzewski said -> but gave it a quick spin and I see that in this case c actually gives better result! It often depends on the specific code example. I am guessing Vince found all these examples to work better with c, so let's do it!

web/docs/language/features.md Outdated Show resolved Hide resolved
@Martinsos Martinsos merged commit 140cbcd into release Nov 26, 2022
@Martinsos Martinsos deleted the vince-deploying-railway-docs branch November 26, 2022 17:02
sodic added a commit that referenced this pull request Nov 26, 2022
@sodic @matijaSos
@maksim36ua @Martinsos @shayneczyzewski @vincanger
Merge release to main (#844)
7c7e6b7 
* Added 'How Wasp got to 1k stars on gh' blog post.

* Docs update for Hacktoberfest (#731)

* Initial docs update for Hacktoberfest

* Contributing.md update

* Update "Before you begin" section

* Update web/docs/tutorials/dev-excuses-app/creating-the-project.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Update the section names

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/contributing.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/contributing.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/contributing.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Add Discord component and some minor fixes

* Add unclear notice

* Update web/docs/pick-a-tutorial.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/getting-started.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Review updates

* Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update suggestion

* Update web/docs/tutorials/dev-excuses-app/perform-migration-and-run.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update web/docs/tutorials/dev-excuses-app/perform-migration-and-run.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update

* Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Remove lines

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update CONTRIBUTING.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update getExcuse function

* Update page naming convention

* Remove Main.css

* Update migration text

* Update image

* Update "Wasp's compiler is built with Haskell"

* Add tutorials description

* Update web/docs/pick-a-tutorial.md

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update Discord link and tutorial ending

* Update links

Co-authored-by: mkhamrov <mkhamrov@redhat.com>
Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>
Co-authored-by: Matija Sosic <matija.sosic@gmail.com>

* Update to-do app tutorial links

* Fixed a bit 'how to get started with haskell in 2022' blog post.

* Small fix of 'Pick a Tutorial' doc page. (#737)

* Linked Copilot post to its HN discussion.

* Added Farnance showcase blog post.

* Improved messaging about node version in getting started page in docs.

* Added Beta announcement bar to the landing page and docs.

* Update Docusaurus (#797)

* Adds Fly.io to deployment guide (#803)

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>
Co-authored-by: vincanger <70215737+vincanger@users.noreply.github.com>

* Added Alpha Testing Program: post-mortem blog post.

* Update features.md newUser snippets

more explicit examples

* add railway deployment (#818)

* Added Hacktoberfest 2022 reflections blog post.

* update Railway client deployment

* add railway proxy warning

* Update image thumbnail (#832)

Co-authored-by: mkhamrov <mkhamrov@redhat.com>

* Added Beta Launch Week announcement post.

* small blog fix, updated thumbnail img.

* Added Michael Curry (cursorial) use case blog post.

* Added Erlis Kllogjri's Amicus use case blog post.

* Fixed some grammar errors in use case posts.

* first pass at both beta launch blog posts

* minor edits

* clean up Features, GoogleAuth, & Deploy docs (#820)

* add railway deployment

* clean up Features and GoogleAuth docs

* Update web/docs/language/features.md

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>
Co-authored-by: Martin Sosic <sosic.martin@gmail.com>

* Created new landing page for Beta.

Co-authored-by: Matija Sosic <matija.sosic@gmail.com>
Co-authored-by: Max Khamrovskyi <maksim36ua@gmail.com>
Co-authored-by: mkhamrov <mkhamrov@redhat.com>
Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>
Co-authored-by: Martin Sosic <sosic.martin@gmail.com>
Co-authored-by: Shayne Czyzewski <523636+shayneczyzewski@users.noreply.github.com>
Co-authored-by: vincanger <70215737+vincanger@users.noreply.github.com>
Co-authored-by: shayneczyzewski <shayne.czyzewski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayneczyzewski shayneczyzewski shayneczyzewski left review comments

@Martinsos Martinsos Martinsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincanger @Martinsos @shayneczyzewski