Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CellDictionaries are incorrect after rotating Cellcomplex #47

Closed
Sinasta opened this issue Oct 8, 2022 · 7 comments
Closed

CellDictionaries are incorrect after rotating Cellcomplex #47

Sinasta opened this issue Oct 8, 2022 · 7 comments

Comments

@Sinasta
Copy link

Sinasta commented Oct 8, 2022

Hello Wassim,
It seems like CellDictionary selectors are not rotated with the Cellcomplex when Topology.Rotate is used.
Screenshot from 2022-10-08 16-34-36
if the rotation is below a certain threshold (very low ~1-5 degrees) then the dictionaries stay correct.
Screenshot from 2022-10-08 16-35-01
This is why i assume that the Dictionary selectors are not rotated with the Cellcomplex. I think in general all the selectors should be affected by transformations of the Supertopology. But It could be that i just don't understand the purpose of them not beeing roatated. If so, i would love to know a way to properly rotate them with the supertopology.
Thanks a lot!

@Sinasta
Copy link
Author

Sinasta commented Oct 8, 2022

I just checked and the same goes for TopologyScale, TopologyPlace, TopologyTranslate and TopologyTransform

@wassimj
Copy link
Owner

wassimj commented Oct 8, 2022

Thanks for reporting this! This seems a bug in the low level C++ code. I can certainly override it in the python code. Can you share the json file of the brep with dictionaries and the blender file? Thank you.

@Sinasta
Copy link
Author

Sinasta commented Oct 8, 2022

Sure! thanks for your response.
I am using opencascade 7.5.3 and you are using 7.6. though. Which means my brep strings in the json are: CASCADE Topology V1, (c) Matra-Datavision.
I am afraid that you wont be able to import them into topologicsverchok on your machine.

A python workaround would be nice. For now i have to rotate all the cells one by one and than merge them into a cellcomplex again afterwards, which results in a considerable performance loss. If you would be able to implement a rotation of only the Dictionary selector vertices than that would be great!

Dictionary_rotation_bug_example.zip

@wassimj
Copy link
Owner

wassimj commented Oct 8, 2022

The next release of TopologicSverchok will ensure backward compatibility of the JSON file between OCCT 7.5.3 and 7.6. This has been solved internally. It just needs to be pushed out to github with the next release.
I am debugging this, but as a quick workaround, you can do the following:
image

@wassimj
Copy link
Owner

wassimj commented Oct 8, 2022

I believe I have solved this with the new release 2022-10-08 0.8.2.5. Please test and report back. Thank you.
P.S. You will need to drag and drop new replacement nodes for all transformations.

@Sinasta
Copy link
Author

Sinasta commented Oct 9, 2022

It is quite impressive to see how fast you implement new features or fix bugs to be honest! Thank you for the new release. I actually converted my blender node trees to pure python scripts thanks to your python bindings so i am not using topologicsverchok for my current project. But i just checked if it works with the updated nodes and it does work perfectly fine now. interesting to see the new EnergyModelExportToIDF node aswell.

@wassimj
Copy link
Owner

wassimj commented Oct 9, 2022

Great to know! and thanks for the kind words :) I will then close this issue. Please feel free to re-open if there is anything else missed. Thanks.

@wassimj wassimj closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants