Improve CLI #102
Merged
Improve CLI #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
commented
Apr 15, 2017
| args, err := parser.ParseArgs(args) | ||
| if err != nil { | ||
| if flagsErr, ok := err.(*flags.Error); ok && flagsErr.Type == flags.ErrHelp { | ||
| fmt.Fprintln(cli.outStream, err) |
There was a problem hiding this comment.
[gometalinter]
- [gas] Errors unhandled.,LOW,HIGH
There was a problem hiding this comment.
Umm... If it can not output to cli.outStream, can not do anything :(
wata727
commented
Apr 15, 2017
| fmt.Fprintln(cli.outStream, err) | ||
| return ExitCodeOK | ||
| } else { | ||
| fmt.Fprintln(cli.errStream, err) |
There was a problem hiding this comment.
[gometalinter]
- [gas] Errors unhandled.,LOW,HIGH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #99
Until now I used golang flag package, but there are many inconvenience in scenes such as error handling of options... So, use go-flags instead of flag package. This package is excellent in terms of handling of unknown option etc.