1174 double get variable #1212
Merged
1174 double get variable #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh yes I did mean to check about creating a new date object. Thanks for catching that. All these changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, finally tracked it down for sure.
I thought errors in the new Date blocks were a clue, but that was just a problem I missed in the code review: we were mutating the arguments, so they were getting changed over and over. I fixed that to clone the arguments instead and date blocks work fine now.
Then I dug some more into the per-frame runtime. I had put some code in last time I worked on this to ensure there was only one handler registered at a time, and to delete that handler when we restarted the script. I put in a quick test to make sure this was working, and that test failed. So I tracked it down to one place where I had forgotten to update the variable holding the current frame runner. Fixed that spot, ran the test and all was well. Could hit play any number of times and the waterbear wouldn't speed up. The Simple Bounce is always going the same speed now too.