Chord block and custom sound effect block #1289
Conversation
|
Are you thinking of synthesized or sampled sound effects? |
|
Synthesized, like the two that are in the list of the current sound effect block. The new block will allow users to make their own though. |
|
Okay, so what if you want a chord consisting of G4, B5, and D5? From what I can tell your interface won't allow that. |
|
@CelticMinstrel Ahh yeah that's true. Thanks I didn't mean to leave that out. It's fixed now. |
|
So rows can contain multiple values, huh? I guess that's good to know. |
…nto new_sound_lib
|
Okay ready to merge! |
|
My tests added some output to |
| }, | ||
| playInstrument: function(sound){ | ||
| playNotes: function(sound){ | ||
| console.log(song); |
There was a problem hiding this comment.
Can you pull out the console logging?
|
Looks good, just a couple of minor things to address and then |
|
Okay I removed the log and alert. The issue for providing info with the keys block is #1311. Merging now 👍 |
Chord block and custom sound effect block
Not ready to merge, chord block is done, just need to make sound effect block.