Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locating element by partial text only considers direct child text nodes #871

Conversation

jkotests
Copy link
Member

Fixes #866

Note that in the SelectorBuilder::XPath that :text and :contains_text are now the same - ie comparing to normalize-space(). From what I could see, there's no reason that they should ever be different. However, for now, to minimize changes, I have left them separate.

@coveralls
Copy link

coveralls commented Jun 18, 2019

Pull Request Test Coverage Report for Build 2003

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.439%

Totals Coverage Status
Change from base Build 2002: 0.0%
Covered Lines: 2321
Relevant Lines: 2382

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 18, 2019

Pull Request Test Coverage Report for Build 2003

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.439%

Totals Coverage Status
Change from base Build 2002: 0.0%
Covered Lines: 2321
Relevant Lines: 2382

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locating element by partial text only considers direct child text nodes
3 participants