-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support region in the watsonx.ai url #268
feat: support region in the watsonx.ai url #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to test this, but it looks fine to me. I would consider dropping the enum as noted in my comment, but I would be OK with this merging either way. Hopefully @rfazeli or someone has time to test this too.
@@ -121,6 +133,9 @@ | |||
}, | |||
"stop_sequences": { | |||
"type": "array", | |||
"items": { | |||
"type": "string" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement.
"default": "us-south", | ||
"description": "The region where you want to access watsonx.ai" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. However, one downside of making this an enum is that it becomes outdated whenever a new region becomes available. Another option would be to drop the enum and just list the current values for it in the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Zach! Looks good to me. Used the new open api specs and the watsonx extension worked fine for me.
This PR adds a region parameter to the watsonx.ai open API spec to allow specifying the region when constructing the server URL. It also updates all the starter-kit workspace JSON files that use the watsonx.ai service.
Signed off by: zhongzheng.shu@ibm.com