This repository has been archived by the owner on Nov 24, 2020. It is now read-only.
Refactor widget queries to live closer to widgets #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besh
reviewed
Aug 11, 2017
| }); | ||
| return Object.assign({}, timesliceResult, { aggregations }); | ||
| }); | ||
| } |
besh
reviewed
Aug 14, 2017
| `term(${fields.title_entity_text})`, | ||
| `timeslice(${fields.publication_date},1day)`, | ||
| `term(${fields.text_document_sentiment_type})`, | ||
| ].join('.'); |
There was a problem hiding this comment.
I really like that you did this. Much more readable.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The widget queries were awfully far away from their actual use, so I moved them closer to each widget.
However, these files do not seem to be auto-reloaded when updated since they are loaded via node instead of webpack during development.