This repository has been archived by the owner on Sep 22, 2021. It is now read-only.
do not use ^M carriage returns in training data #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not very unix friendly to use ^M, so remove it and actually use new lines. Currently, when cat'ing the file it will only produce one line of content.
|
to the reviewers, note that i haven't actually tested that this still works, but i'm assuming the API services normalizes the csv content. if it's smart enough to handle ^M's, as it does today, then it should handle this format, too. |
germanattanasio
approved these changes
Nov 27, 2017
|
Thanks @stevemart |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not very unix friendly to use ^M, so remove it and actually use new lines. Currently, when cat'ing the file it will only produce one line of content.