feat: add support for new authenticators in all sdks #946

dpopp07 · 2019-08-29T22:59:25Z

All service regenerated
Core version updated to use release-candidate-v1 branch
Authenticators required (and exported from the watson sdk)
All parameters changed to lower camel case
Only detailed response is returned

Many of the breaking changes come just from the core version changing.

All breaking changes described in the Migration Guide.

I will release the RC once this is merged.

BREAKING CHANGE: Passing individual credentials to the service constructor will no longer work. An Authenticator must be initialized and passed in. For more information, see the migration guide.

mediumTaj

👍 This looks good! I think you're making some changes for the tests but so far this looks good once we get everything passing

mediumTaj · 2019-08-30T15:48:09Z

UPGRADE-5.0.md

+
+#### Visual Recognition
+- Property `class_name` renamed to `_class` in interface `ClassResult`
+


totally gonna steal this 👍

mediumTaj · 2019-08-30T16:20:28Z

lib/recognize-stream.ts

@@ -230,7 +232,7 @@ class RecognizeStream extends Duplex {
      null,
      options.headers,
      null,
-      { tlsOptions: { rejectUnauthorized: options.rejectUnauthorized }}
+      { tlsOptions: { rejectUnauthorized: !options.disableSslVerification }}


package.json

codecov-io · 2019-08-30T20:17:01Z

Codecov Report

Merging #946 into release-candidate-v5 will increase coverage by 0.43%.
The diff coverage is 42.43%.

@@                   Coverage Diff                    @@
##           release-candidate-v5     #946      +/-   ##
========================================================
+ Coverage                 54.49%   54.92%   +0.43%     
========================================================
  Files                        19       20       +1     
  Lines                      4487     4564      +77     
  Branches                    898      904       +6     
========================================================
+ Hits                       2445     2507      +62     
- Misses                     2041     2056      +15     
  Partials                      1        1

Impacted Files	Coverage Δ
assistant/v1.ts	`76.06% <ø> (-0.01%)`	⬇️
discovery/v1.ts	`34.19% <ø> (+0.15%)`	⬆️
lib/websocket-utils.ts	`90% <ø> (+5%)`	⬆️
speech-to-text/v1-generated.ts	`42.44% <ø> (+3.66%)`	⬆️
auth/index.ts	`100% <100%> (ø)`
test/resources/service_error_util.js	`80% <100%> (ø)`	⬆️
lib/synthesize-stream.ts	`83.33% <100%> (+0.35%)`	⬆️
lib/recognize-stream.ts	`65.94% <100%> (-2.68%)`	⬇️
text-to-speech/v1.ts	`44.73% <100%> (-1.61%)`	⬇️
visual-recognition/v3.ts	`37.93% <18.75%> (+1.46%)`	⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa522c...db864c4. Read the comment docs.

watson-github-bot · 2019-08-30T20:22:10Z

Service Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

Possible Test Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

watson-github-bot · 2019-08-30T20:23:47Z

Service Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

Possible Test Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

mediumTaj

👍 looks good! Lets update the readme after the pre-release

watson-github-bot · 2019-08-30T20:33:57Z

Service Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

Possible Test Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

watson-github-bot · 2019-08-30T20:35:31Z

Service Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

Possible Test Failures

/integration/assistant.v1.test.js

/integration/discovery.test.js

/integration/speech_to_text.test.js

/integration/compare_comply.test.js

/integration/visual_recognition.custom_classifiers.test.js

/integration/text_to_speech.test.js

/integration/visual_recognition.test.js

/integration/language_translator.v3.test.js

/integration/assistant.v2.test.js

/integration/tone_analyzer.test.js

/integration/personality_insights.v3.test.js

/integration/natural_language_classifier.test.js

watson-github-bot · 2019-08-30T20:46:03Z

Service Failures

/integration/speech_to_text.test.js

Possible Test Failures

/integration/speech_to_text.test.js

watson-github-bot · 2019-08-30T20:47:45Z

Service Failures

/integration/speech_to_text.test.js

Possible Test Failures

/integration/speech_to_text.test.js

…ice features for major release (#946) BREAKING CHANGE: Passing individual credentials to the service constructor will no longer work. An Authenticator must be initialized and passed in. For more information, see the migration guide.

# [5.0.0](v4.5.1...v5.0.0) (2019-10-04) ### Bug Fixes * make RecognizeStream.readableObjectMode always return Boolean ([#943](#943)) ([a276df4](a276df4)) ### Build System * drop support for Node versions 6 and 8 ([3ea1fd7](3ea1fd7)) ### Code Refactoring * change all websocket method parameters to lower camel case ([#941](#941)) ([cb6711f](cb6711f)) ### Features * add support for new authenticators in all sdks and add new service features for major release ([#946](#946)) ([3acffc5](3acffc5)) ### BREAKING CHANGES * Passing individual credentials to the service constructor will no longer work. An Authenticator must be initialized and passed in. For more information, see the migration guide. * All parameters have been converted to their lower camel case version. * Support for the `token` parameter has been removed * Support for the `customization_id` parameter has been removed * Method `setAuthorizationHeaderToken` has been removed from the WebSocket Stream classes * `RecognizeStream.readableObjectMode` will always be a Boolean value - before, it could have been `undefined`. * This SDK may no longer work with applications running on Node 6 or 8.

feat: add support for new authenticators in all sdks

5f5508e

BREAKING CHANGE: Passing individual credentials to the service constructor will no longer work. An Authenticator must be initialized and passed in. For more information, see the migration guide.

dpopp07 requested review from germanattanasio and mediumTaj August 29, 2019 22:59

mediumTaj reviewed Aug 30, 2019

View reviewed changes

test: update integration tests to account for breaking changes

2ba52ee

ci: update credentials on travis

a280e8c

mediumTaj approved these changes Aug 30, 2019

View reviewed changes

test: don't try to access auth file before describe block

db864c4

dpopp07 force-pushed the pre-release-generation branch from 163a892 to db864c4 Compare August 30, 2019 21:02

dpopp07 merged commit 5074a52 into release-candidate-v5 Aug 30, 2019

dpopp07 deleted the pre-release-generation branch August 30, 2019 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for new authenticators in all sdks #946

feat: add support for new authenticators in all sdks #946

dpopp07 commented Aug 29, 2019

mediumTaj left a comment

mediumTaj Aug 30, 2019

mediumTaj Aug 30, 2019

codecov-io commented Aug 30, 2019 •

edited

Loading

watson-github-bot commented Aug 30, 2019

watson-github-bot commented Aug 30, 2019

mediumTaj left a comment

watson-github-bot commented Aug 30, 2019

watson-github-bot commented Aug 30, 2019

watson-github-bot commented Aug 30, 2019

watson-github-bot commented Aug 30, 2019


		#### Visual Recognition
		- Property `class_name` renamed to `_class` in interface `ClassResult`

feat: add support for new authenticators in all sdks #946

feat: add support for new authenticators in all sdks #946

Conversation

dpopp07 commented Aug 29, 2019

mediumTaj left a comment

Choose a reason for hiding this comment

mediumTaj Aug 30, 2019

Choose a reason for hiding this comment

mediumTaj Aug 30, 2019

Choose a reason for hiding this comment

codecov-io commented Aug 30, 2019 • edited Loading

Codecov Report

watson-github-bot commented Aug 30, 2019

Service Failures

Possible Test Failures

watson-github-bot commented Aug 30, 2019

Service Failures

Possible Test Failures

mediumTaj left a comment

Choose a reason for hiding this comment

watson-github-bot commented Aug 30, 2019

Service Failures

Possible Test Failures

watson-github-bot commented Aug 30, 2019

Service Failures

Possible Test Failures

watson-github-bot commented Aug 30, 2019

Service Failures

Possible Test Failures

watson-github-bot commented Aug 30, 2019

Service Failures

Possible Test Failures

codecov-io commented Aug 30, 2019 •

edited

Loading