Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dotenv as direct dependency #958

Merged
merged 1 commit into from
Sep 17, 2019
Merged

refactor: remove dotenv as direct dependency #958

merged 1 commit into from
Sep 17, 2019

Conversation

MasterOdin
Copy link
Contributor

dotenv was used back when ibm-cloud-sdk-core was part of this package, but since it was removed, dotenv is no longer directly used in any of the code except under some of the examples. It does remain in the tree though, so no change to package-lock.json:

ibm-watson@5.0.0-rc1 /Users/mpeveler/work/github/node-sdk
├─┬ ibm-cloud-sdk-core@1.0.0-rc1
│ └── dotenv@6.2.0
└─┬ semantic-release@15.13.24
  └─┬ @semantic-release/npm@5.1.15
    └─┬ npm@6.11.3
      └─┬ libnpx@10.2.0
        └── dotenv@5.0.1
Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #958 into release-candidate-v5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           release-candidate-v5     #958   +/-   ##
=====================================================
  Coverage                 64.28%   64.28%           
=====================================================
  Files                         2        2           
  Lines                        14       14           
  Branches                      3        3           
=====================================================
  Hits                          9        9           
  Misses                        4        4           
  Partials                      1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73a747...acc0fa9. Read the comment docs.

Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@dpopp07 dpopp07 merged commit ac29153 into watson-developer-cloud:release-candidate-v5 Sep 17, 2019
dpopp07 pushed a commit that referenced this pull request Sep 19, 2019
was used back when `ibm-cloud-sdk-core` was part of this package, but since it was removed, dotenv is no longer directly used in any of the code
@MasterOdin MasterOdin deleted the dotenv branch September 27, 2019 12:00
dpopp07 pushed a commit that referenced this pull request Oct 4, 2019
was used back when `ibm-cloud-sdk-core` was part of this package, but since it was removed, dotenv is no longer directly used in any of the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants