refactor: add typings for tts/v1 #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
commented
Sep 23, 2019
dpopp07
requested changes
Sep 23, 2019
Codecov Report
@@ Coverage Diff @@
## release-v5-rc2 #968 +/- ##
===================================================
+ Coverage 77.77% 88.88% +11.11%
===================================================
Files 1 1
Lines 9 9
Branches 2 2
===================================================
+ Hits 7 8 +1
+ Misses 2 1 -1
Continue to review full report at Codecov.
|
dpopp07
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typings for
text-to-speech/v1.ts, using a similar approach as thespeech-to-text/v1.tstypings in that the Stream Options are split across the two files as appropriate.Checklist
npm testpasses (tip:npm run autofixcan correct most style issues)