Release/8.8.5 - Layout config option, created option to extend promo repository #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
breakdancingcat
commented
Feb 26, 2024
breakdancingcat
commented
- Added layout config option, created option to extend promo repository
- Sites are made with "main" layout, if you are upgrading an old site, make sure to go change it to "contained-hero."
Feature/refactor 4
no message
Text overlay mobile design 8.8.3
…content area would need to be changed
…ing global promos outside of the config
Feature/layout
…o or small banner layout
…framework Feature/extending-repository - Created the framework for extending the promo repository for global promos, so we do not have to edit the promo repository file and upgrades are cleaner.
breakdancingcat
temporarily deployed
to
build
GitHub Actions
Inactive
chrispelzer
requested changes
Feb 27, 2024
| { | ||
| /* | ||
| // Extend a Styleguide repository | ||
| $promoRepoRequestData = app()->make(PromoRepository::class)->getRequestData($data); |
There was a problem hiding this comment.
Can remove the make() and make it become
app(PromoRepository::class)->getRequestData($data)
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "base", | |||
| "private": true, | |||
| "version": "8.8.4", | |||
| "version": "8.8.5", | |||
There was a problem hiding this comment.
Would put this to 8.9.0 rather than patch version bump, just due to the overall layout changes that happened
|
Closing this and creating a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.