Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/8.9.0 - Site layout option, extend promo repository framework #700

Merged
merged 19 commits into from
Feb 28, 2024
Merged

Release/8.9.0 - Site layout option, extend promo repository framework #700

merged 19 commits into from
Feb 28, 2024

Conversation

breakdancingcat
Copy link
Member

  • Added layout config option, created option to extend promo repository
  • Sites are made with "main" layout, if you are upgrading an old site, make sure to go change it to "contained-hero."

breakdancingcat and others added 18 commits February 1, 2024 15:45
@breakdancingcat
Not ready for release yet
04e7bd5
@breakdancingcat
Merge pull request #693 from waynestate/feature/refactor-4
5e5211f 
Feature/refactor 4
@chrispelzer
Merge tag '8.8.1' into develop
d11379c
@chrispelzer
Merge tag '8.8.2' into develop
43cfd9f 
no message
@breakdancingcat
Merge tag '8.8.3' into develop
a7fd866 
Text overlay mobile design 8.8.3
@breakdancingcat
Created the ability to use a different layout for instances when the …
c6c3e80 
…content area would need to be changed
@breakdancingcat
Accidentally committed all these bak files
736caed
@breakdancingcat
Broke apart get request data function to allow for extending when add…
7ea5b46 
…ing global promos outside of the config
@breakdancingcat
Updating promo repo contract
01955dd
@breakdancingcat
Adding a framework for extending a repository to avoid editing app files
2cd5a02
@breakdancingcat
Merge pull request #697 from waynestate/feature/layout
7e0ec5f 
Feature/layout
@breakdancingcat
Adding framework to extend on the global repository
e6008d5
@breakdancingcat
Adding framework to extend on the global repository
76b7778
@breakdancingcat
Merge branch 'develop' into feature/extending-repository-framework
44a2f56
@breakdancingcat
Additional hero logic
55183ff
@breakdancingcat
Adding default hero to childpage to see if we are using contained her…
dffde4b 
…o or small banner layout
@breakdancingcat
Merge pull request #698 from waynestate/feature/extending-repository-…
fc89cb6 
…framework

Feature/extending-repository - Created the framework for extending the promo repository for global promos, so we do not have to edit the promo repository file and upgrades are cleaner.
@breakdancingcat
Updated the styleguide with layout information
1c6728c
@breakdancingcat breakdancingcat requested a review from a team as a code owner February 27, 2024 19:43
nickdenardis
nickdenardis approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling d5e9704 on release/8.9.0
into 2d0013e on master.

@breakdancingcat breakdancingcat merged commit 02374e0 into master Feb 28, 2024
2 checks passed
@breakdancingcat breakdancingcat deleted the release/8.9.0 branch February 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdenardis nickdenardis nickdenardis approved these changes

@chrispelzer chrispelzer chrispelzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@breakdancingcat @coveralls @nickdenardis @chrispelzer