Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXIF rotation isn't supported #3

Closed
fkxr-dev opened this issue Dec 22, 2023 · 6 comments
Closed

EXIF rotation isn't supported #3

fkxr-dev opened this issue Dec 22, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@fkxr-dev
Copy link

Hey- I really like this minimal set-up and am trying to get a super simple 'upload from iphone' workflow for a trip log going. I ran into a problem though; the rotation information that gets encoded in the jpegs doesn't seem to be respected? I'm seeing photos taken in landscape show up as portrait on the site eventually.

It's addressed easily enough with some shell scripting but it would definitely be more convenient to not have to do manually.

@waynezhang
Copy link
Owner

waynezhang commented Dec 29, 2023

@fkxr-dev thanks for reporting this issue!
I just pushed a fix for this. Could you please try it?
It's also included in newest 1.0.6 version.

Note:
Current cache needed to be deleted so I also added a clear-cache command for this. Please take a backup of your data before trying :)

@waynezhang waynezhang self-assigned this Dec 29, 2023
@waynezhang waynezhang added the bug Something isn't working label Dec 30, 2023
@fkxr-dev
Copy link
Author

fkxr-dev commented Dec 30, 2023

Confirming this has fixed my issue; the images (at least the ones converted with exiftool and ImageMagick from Apple ProRaw and HEIC respectively) seem to be coming in correctly rotated as per EXIF info. Thank you!

@fkxr-dev
Copy link
Author

Actually- I still have some files showing up incorrectly, let me reopen this for now and I will sit down and verify I’ve got everything built correctly, and if so- I’ll get a sample image if anything is still not working. Will check back on this in a few days.

@fkxr-dev fkxr-dev reopened this Dec 31, 2023
@fkxr-dev
Copy link
Author

OK- sorry for the quick ping-pong, found some time to check. Confirming on:

foto v1.0.7+70e7ddd

the images appear correctly rotated.

I was apparently having issues building latest from source; so my previous test was running against an older binary and I didn't notice. Will troubleshoot the building issues separately (undefined values coming out of exp@v0.0.0-20231226003508-02704c960a9b/slog probably some version mismatch).

@waynezhang
Copy link
Owner

#4 (comment)

Rotation in generated index.html is incorrect. Reopen.

@waynezhang waynezhang reopened this Jan 2, 2024
@waynezhang
Copy link
Owner

@fkxr-dev should be fixed in the newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants