Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable in setChar function #1

Closed
wayoda opened this issue Mar 7, 2014 · 1 comment
Closed

Unused variable in setChar function #1

wayoda opened this issue Mar 7, 2014 · 1 comment

Comments

@wayoda
Copy link
Owner

wayoda commented Mar 7, 2014

This issue was was reported by mail :


Hi,

In LedControl::setChar, I think the following is incorrect:

    index=(byte)value;
    if(index >127) {
    //nothing define we use the space char
    value=32;
    }
    v=charTable[index];

Shouldn't it be:

    index=(byte)value;
    if(index >127) {
    //nothing define we use the space char
    index =32;
    }
    v=charTable[index];

Since 'value' is not used anywhere else!

Cheers,
Zheng

@wayoda
Copy link
Owner Author

wayoda commented Mar 7, 2014

An error obviously.
Thanks Zheng

@wayoda wayoda closed this as completed Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant