Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend "Add new agent" component #1767

Closed
6 tasks done
jesusgn90 opened this issue Sep 3, 2019 · 6 comments
Closed
6 tasks done

Extend "Add new agent" component #1767

jesusgn90 opened this issue Sep 3, 2019 · 6 comments
Assignees
Labels
type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side
Milestone

Comments

@jesusgn90
Copy link
Contributor

jesusgn90 commented Sep 3, 2019

The new component where we are explaining to the user how to register agents and we are providing a "copy & paste" dynamic snippet is cool, however, it should be used in more places of the Wazuh app.

Proposals:

  • If the app has API entries and the API tells us there are no agents, show the component to the user, for example in Overview.
    • If there are not metrics of agents in Overview show the component
    • If there are not agents and go to Management > Groups show the component.
  • Make it accessible from more place with light buttons/icons so the user can launch the component almost everywhere.
  • Take the Wazuh manager IP address from the selected API.
  • Option to add the WAZUH_PASSWORD
@jesusgn90 jesusgn90 added type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side priority/low labels Sep 3, 2019
@jesusgn90 jesusgn90 added this to the 38th week sprint milestone Sep 3, 2019
@adri9valle
Copy link
Contributor

Update 12.09.19

Now the component gets the selected API address and the address input is filled with it. Also, is detected if it is necessary the use of the password in order to register a new agent and in this case an extra input is shown in order to type the password.

image

add-agent-extend-1

Branch: extend-add-new-agent-1767

@jsanchez91 jsanchez91 self-assigned this Sep 20, 2019
@jsanchez91
Copy link
Contributor

Pull Request 1818

New improvements:

  • The IP field of the component is autocompleted by the Wazuh-API

  • If the -P option is enabled in the Wazuh manager, show entry to complete

  • The component is showed in the overview
    in_overview

  • The component is showed in management -> groups
    in_management_groups

@juankaromo juankaromo modified the milestones: Sprint - 100, Sprint - 101 Sep 30, 2019
@jsanchez91
Copy link
Contributor

Added the component in the management => groups view.

groups_add_new_agent

@jsanchez91
Copy link
Contributor

The component is removed from Managents -> Groups because throw an error when navigate to:
agents -> [any agent] -> configuration -> groups [any group]

@adri9valle
Copy link
Contributor

Solved #1818

@branchnetconsulting
Copy link

branchnetconsulting commented Nov 8, 2019

With reference to the below example of incorporating the Wazuh registration password into the "Add new agent" form, I noticed that the wrong deployment variable names were appearing in the example animation below, referring the PASSWORD and to WAZUH_PASSWORD instead of the WAZUH_REGISTRATION_PASSWORD name that I understand to be correct according to https://documentation.wazuh.com/3.10/installation-guide/installing-wazuh-agent/deployment_variables.html
Likely this has already been fixed, but I bring it up just in case.

Kevin

Update 12.09.19

Now the component gets the selected API address and the address input is filled with it. Also, is detected if it is necessary the use of the password in order to register a new agent and in this case an extra input is shown in order to type the password.

image

add-agent-extend-1

Branch: extend-add-new-agent-1767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side
Projects
None yet
Development

No branches or pull requests

5 participants