Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed permissions to access agents #2838

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Fixed permissions to access agents #2838

merged 1 commit into from
Jan 26, 2021

Conversation

gabiwassan
Copy link
Contributor

Hi team, this PR resolves:

  • A user is able to see the list of its allowed agents, at first is only able to see agent 001 and by adding permissions to read agent 002 it appears in its list after refreshing.

Issue: #2801 (comment)

@gabiwassan gabiwassan requested a review from a team January 25, 2021 20:00
@gabiwassan gabiwassan changed the title Fixed permissions to access angents view with a perticular agent. Add… Fixed permissions to access angents Jan 26, 2021
frankeros
frankeros approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao changed the title Fixed permissions to access angents Fixed permissions to access agents Jan 26, 2021
@Desvelao
Copy link
Member

I tested the PR and it's working:
image

With 4.0-7.10 branch:
image

Using the next permissions: action: agent:read resource: agent:id:{agentID}
image

@Desvelao Desvelao self-requested a review January 26, 2021 16:48
Desvelao
Desvelao approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit b2d6cdb into 4.0-7.10 Jan 26, 2021
@Desvelao Desvelao deleted the fix/4.0-7.10-agents-permissions branch January 26, 2021 17:57
@frankeros frankeros linked an issue Jan 26, 2021 that may be closed by this pull request
Testing 4.0.4-7.10.0 #2801
Closed
3 tasks
@frankeros frankeros mentioned this pull request Jan 28, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@frankeros frankeros frankeros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing 4.0.4-7.10.0
3 participants
@gabiwassan @Desvelao @frankeros