Create modular view office365 GitHub #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/3489 query config refactor
add searchbar component
…ice365-github-3422
- Subscribe to the changes
…ctor_use-filter-manager Revert "Moved filter subscription to useFilterManager"
…drilldownConfig by id. Applied TS on files.
…an object Switched useState by useMemo in use-filter-manager
Removed subscription handling from useEsSearch
…ter-manager Enhancement/3512 refactor use filter manager
mpRegalado
reviewed
Jul 30, 2021
public/components/common/custom-search-bar/custom-search-bar.tsx
Outdated
Show resolved
Hide resolved
public/components/common/custom-search-bar/custom-search-bar.tsx
Outdated
Show resolved
Hide resolved
public/components/common/custom-search-bar/custom-search-bar.tsx
Outdated
Show resolved
Hide resolved
public/components/common/custom-search-bar/custom-search-bar.tsx
Outdated
Show resolved
Hide resolved
| const { unsubscribe } = getDataPlugin().query.queryString.getUpdates$().subscribe((q) => { | ||
| setQuery(q); | ||
| }); | ||
| return () => unsubscribe(); |
There was a problem hiding this comment.
We must remember to check whether this unsubscription works correctly before merging
CPAlejandro
reviewed
Jul 30, 2021
…ttps://github.com/wazuh/wazuh-kibana-app into feature/create-modular-view-office365-github-3422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
this sets a base module with an Office 365 case of use
Closes #3421 #3422 #3493 #3463