Fix creation of log files #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabiwassan
approved these changes
Jun 22, 2021
Desvelao
reviewed
Jun 23, 2021
Comment on lines
+41
to
+42
| this.PLAIN_LOGS_PATH = path.join(WAZUH_DATA_LOGS_DIRECTORY_PATH, plainLogsFile); | ||
| this.RAW_LOGS_PATH = path.join(WAZUH_DATA_LOGS_DIRECTORY_PATH, rawLogsFile); |
There was a problem hiding this comment.
thought:: Could we move the variable that stores the path of these files to the constants.ts file?
Desvelao
reviewed
Jun 23, 2021
|
issue: The filename looks a little bit weird. suggestion: Here it is the filename had before the changes: https://github.com/wazuh/wazuh-kibana-app/blob/12ad00eedf03e6625493b05d8ba9a9e6fff48a4e/server/lib/logger.ts#L105-L108
|
Desvelao
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team this PR solves a problem related with the creation of the log files, adding a condition that if the file does not exist it will be created. Also solves a problem with the rotation of the log file if it's size is over 100MB.