Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor try catch strategy on Overview section. #3408

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Refactor try catch strategy on Overview section. #3408

merged 6 commits into from
Jun 30, 2021

Conversation

gabiwassan
Copy link
Contributor

Hi team,
This PR implements a new strategy to catch and store/show errors in the Overview section.

Close: #3407

@gabiwassan gabiwassan self-assigned this Jun 28, 2021
Machi3mfl
Machi3mfl approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabiwassan gabiwassan merged commit 0153e2a into 4.3-7.10 Jun 30, 2021
@gabiwassan gabiwassan deleted the feature/trycatch-overview branch June 30, 2021 19:22
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@asteriscos asteriscos Awaiting requested review from asteriscos

@frankeros frankeros Awaiting requested review from frankeros

@pablomarga pablomarga Awaiting requested review from pablomarga

@matiasmoreno876 matiasmoreno876 Awaiting requested review from matiasmoreno876

Assignees

@gabiwassan gabiwassan

Labels
error-handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabiwassan @Machi3mfl