Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Remove URL query param redirectRule on CDB Lists/Decoders #3438

Merged
merged 4 commits into from
Jul 21, 2021
Merged

[Fix] Remove URL query param redirectRule on CDB Lists/Decoders #3438

merged 4 commits into from
Jul 21, 2021

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jul 5, 2021

Description

Remove unnecessary URL param in CDB Lists/Decoders when clink to expand the details about the list/decoder.

This PR removes from the URL:

redirectRule=undefined

Testing

For CDB Lists and Decoders:

  1. Go to section
  2. Click in a table row to expand the details and review the URL that doesn't contain the redirectRule query param.
  • For the Rules section the query param should appear when clicking on the table row to expand the details.

Closes: #3356

@Desvelao Desvelao added the type/bug Bug issue label Jul 5, 2021
@Desvelao Desvelao self-assigned this Jul 5, 2021
@Desvelao Desvelao linked an issue Jul 5, 2021 that may be closed by this pull request
Clicking CDB List adds redirectRule undefined parameter to URL #3356
Closed
pablomarga
pablomarga approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Testing: ✔️

mpRegalado
mpRegalado approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM ✔️
Testing: LGTM ✔️

frankeros
frankeros approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit 6cefc4f into 4.3-7.10 Jul 21, 2021
@frankeros frankeros deleted the fix/3356-remove-url-param-redirectRule-on-lists-decoders branch July 21, 2021 12:33
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.66% ( 1304 / 35653 )
Branches 1.46% ( 409 / 28085 )
Functions 2.56% ( 221 / 8616 )
Lines 3.7% ( 1260 / 34089 )

gabiwassan pushed a commit that referenced this pull request Jul 30, 2021
@Desvelao @gabiwassan
[Fix] Remove URL query param redirectRule on CDB Lists/Decoders (#3438
07b86ad 
)

* fix(frontend): Remove URL param redirectRule on Lists and Decoders when clicking on a list/decoder
gabiwassan pushed a commit that referenced this pull request Aug 5, 2021
@Desvelao @gabiwassan
[Fix] Remove URL query param redirectRule on CDB Lists/Decoders (#3438
f85d35f 
)

* fix(frontend): Remove URL param redirectRule on Lists and Decoders when clicking on a list/decoder
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
@MauGaP MauGaP mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpRegalado mpRegalado mpRegalado approved these changes

@pablomarga pablomarga pablomarga approved these changes

@frankeros frankeros frankeros approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking CDB List adds redirectRule undefined parameter to URL
4 participants
@Desvelao @frankeros @pablomarga @mpRegalado