Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor try-catch components/add-moludes-data #3472

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Refactor try-catch components/add-moludes-data #3472

merged 3 commits into from
Jul 19, 2021

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Jul 13, 2021 •
edited
Loading

Hi team,
This PR implements a new strategy to catch in components/add-modules-data.

Close: #3471

@Machi3mfl Machi3mfl self-assigned this Jul 13, 2021
gabiwassan
gabiwassan approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

matiasmoreno876
matiasmoreno876 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Machi3mfl Machi3mfl mentioned this pull request Jul 14, 2021
Closed
25 tasks
pablomarga
pablomarga approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpRegalado mpRegalado linked an issue Jul 15, 2021 that may be closed by this pull request
Refactor try catch in componets/add-modules-data #3471
Closed
@MauGaP MauGaP self-assigned this Jul 16, 2021
@MauGaP
Copy link
Contributor

MauGaP commented Jul 16, 2021

you will need to update changelog in order to merge this one

@gabiwassan gabiwassan merged commit d161e45 into 4.3-7.10 Jul 19, 2021
@gabiwassan gabiwassan deleted the feature/3471-try-catch-add-moludes-data branch July 19, 2021 11:48
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.12% ( 1109 / 35579 )
Branches 1.16% ( 324 / 27953 )
Functions 2.01% ( 174 / 8642 )
Lines 3.15% ( 1071 / 34005 )

Machi3mfl added a commit that referenced this pull request Jul 19, 2021
@Machi3mfl @gabiwassan
Refactor try-catch components/add-moludes-data (#3472)
0a32d1a 
* Implemented error-handling

* Updated CHANGELOG

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
gabiwassan added a commit that referenced this pull request Aug 5, 2021
@Machi3mfl @gabiwassan
Refactor try-catch components/add-moludes-data (#3472)
76d4713 
* Implemented error-handling

* Updated CHANGELOG

Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com>
@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasmoreno876 matiasmoreno876 matiasmoreno876 approved these changes

@pablomarga pablomarga pablomarga approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees

@Machi3mfl Machi3mfl

@MauGaP MauGaP

Labels
error-handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor try catch in componets/add-modules-data
5 participants
@Machi3mfl @MauGaP @gabiwassan @pablomarga @matiasmoreno876