Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [Module] [Mitre Att&ck] [Framework] Double fetching alerts count on pin/unpin agent #3484

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

Desvelao
Copy link
Member

Description

This PR solves a problem with double fetching alerts count in Mitre Att&ck/Framework.

Changes

  • Fix double fetching the alerts count in Modules/Mitre Att&ck/Framework when pin/unpin agent using the Explore agent button.

Tests

  • Go to Modules/Mitre Att&ck/Framework and review that only fetch one time the alerts count when pinning/unpinning the agent

Closes #3363

…Framework due to changes in the filters, redid the request.

  - Added a conditional when the selected tab is inventory
@Desvelao Desvelao added the type/bug Bug issue label Jul 15, 2021
@Desvelao Desvelao requested a review from a team July 15, 2021 13:35
@Desvelao Desvelao self-assigned this Jul 15, 2021
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.01% ( 1071 / 35560 )
Branches 1.12% ( 314 / 27938 )
Functions 1.93% ( 167 / 8642 )
Lines 3.04% ( 1034 / 33987 )

Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM!
Testing: LGTM!

Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Testing: ✔️

Copy link
Member

@mpRegalado mpRegalado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: LGTM ✔️
Testing: LGTM ✔️

Merged 4.3-7.10 to fix an error when entering the framework tab

@Mayons
Copy link

Mayons commented Jan 5, 2022

This bug is still reproducible.
I proceed to reopen this issue.

Evidence: https://drive.google.com/file/d/1Wip1mrupicm7wKwiHn_91CNN0jZ9ooHL/view?usp=sharing
@Desvelao @MauGaP @mauceballos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants