-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] [Module] [Mitre Att&ck] [Framework] Double fetching alerts count on pin/unpin agent #3484
Conversation
…Framework due to changes in the filters, redid the request. - Added a conditional when the selected tab is inventory
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: LGTM!
Testing: LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✔️
Testing: ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: LGTM ✔️
Testing: LGTM ✔️
Merged 4.3-7.10 to fix an error when entering the framework tab
This bug is still reproducible. Evidence: https://drive.google.com/file/d/1Wip1mrupicm7wKwiHn_91CNN0jZ9ooHL/view?usp=sharing |
Description
This PR solves a problem with double fetching alerts count in Mitre Att&ck/Framework.
Changes
Modules/Mitre Att&ck/Framework
when pin/unpin agent using theExplore agent
button.Tests
Modules/Mitre Att&ck/Framework
and review that only fetch one time the alerts count when pinning/unpinning the agentCloses #3363