Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated deprecated and new references authd #3663

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Updated deprecated and new references authd #3663

merged 5 commits into from
Nov 30, 2021

Conversation

Machi3mfl
Copy link
Member

Hi Team,
This PR updates the authd configuration.

Closes #3597

@Machi3mfl Machi3mfl requested a review from a team October 22, 2021 18:37
@CPAlejandro
Copy link
Contributor

Changelog.md is missing and could you add the steps to test it?

@Machi3mfl
Copy link
Member Author

This PR depends on this API Epic issue.
The API solution is implemented in this wazuh/wazuh branch.

To test it, the wazuh API must be created from dev-9550-authd-replacement-configurations-improvement branch.

@Machi3mfl
Copy link
Member Author

Changelog.md is missing and could you add the steps to test it?

@CPAlejandro, to test it, the wazuh API must be created from dev-9550-authd-replacement-configurations-improvement branch.
I added an issue comment with screenshots and a video showing the solution.

frankeros
frankeros approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DProvinciani DProvinciani linked an issue Nov 4, 2021 that may be closed by this pull request
Update references to authd new and deprecated options. #3597
Closed
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.98% ( 1443 / 36287 )
Branches 1.6% ( 453 / 28324 )
Functions 2.92% ( 259 / 8882 )
Lines 4.03% ( 1398 / 34675 )

@Machi3mfl Machi3mfl changed the title Updated depracated and new references authd Updated deprecated and new references authd Nov 15, 2021
gabiwassan
gabiwassan approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

eze9252
eze9252 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Machi3mfl Machi3mfl added the 4.3 label Nov 30, 2021
@MauGaP MauGaP changed the base branch from 4.3-7.10 to 4.3-7.10---RC1 November 30, 2021 14:07
@MauGaP MauGaP merged commit 62202a9 into 4.3-7.10---RC1 Nov 30, 2021
@MauGaP MauGaP deleted the feature/3597-updated-depracated-authd branch November 30, 2021 14:07
@MauGaP MauGaP mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eze9252 eze9252 eze9252 approved these changes

@frankeros frankeros frankeros approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update references to authd new and deprecated options.
6 participants
@Machi3mfl @CPAlejandro @gabiwassan @frankeros @eze9252 @MauGaP