Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/3627 be able select columns in agents #3691

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Feature/3627 be able select columns in agents #3691

merged 4 commits into from
Dec 1, 2021

Conversation

eze9252
Copy link
Contributor

@eze9252 eze9252 commented Nov 19, 2021 •
edited
Loading

Hi Team,
This PR add the ability to filter the columns you want to see in the agents table and persist during the session.

Closes #3627

How to test:

  1. Go to agents:

Captura de pantalla de 2021-11-19 17-51-22

  1. Click in select columns table:

Captura de pantalla de 2021-11-19 17-54-50

  1. Modify the filters and have the changes applied to the table

@eze9252 eze9252 linked an issue Nov 19, 2021 that may be closed by this pull request
Feature request: Be able to select and toggle columns in the Agent dashboard #3627
Closed
@eze9252 eze9252 self-assigned this Nov 19, 2021
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.97% ( 1443 / 36383 )
Branches 1.59% ( 453 / 28406 )
Functions 2.91% ( 259 / 8900 )
Lines 4.02% ( 1398 / 34769 )

Machi3mfl
Machi3mfl approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Machi3mfl Machi3mfl requested a review from a team November 30, 2021 10:45
CPAlejandro
CPAlejandro approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and Testing: LGTM!

CPAlejandro
CPAlejandro suggested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@CPAlejandro CPAlejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in Changelog.md is missing

@Machi3mfl Machi3mfl added the 4.3 label Nov 30, 2021
@MauGaP MauGaP changed the base branch from 4.3-7.10 to 4.3-7.10---RC1 November 30, 2021 13:57
@eze9252 eze9252 merged commit 74abbd8 into 4.3-7.10---RC1 Dec 1, 2021
@eze9252 eze9252 deleted the feature/3627-be-able-select-columns-in-agents branch December 1, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPAlejandro CPAlejandro CPAlejandro requested changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@eze9252 eze9252

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Be able to select and toggle columns in the Agent dashboard
3 participants
@eze9252 @Machi3mfl @CPAlejandro